Add sig and hea stream parameters to rdrecord, rdheader and rdann#491
Open
Ivorforce wants to merge 2 commits intoMIT-LCP:mainfrom
Open
Add sig and hea stream parameters to rdrecord, rdheader and rdann#491Ivorforce wants to merge 2 commits intoMIT-LCP:mainfrom
Ivorforce wants to merge 2 commits intoMIT-LCP:mainfrom
Conversation
Ivorforce
changed the title
… rdann, in case the file is not read from disk.
Ivorforce
changed the title
Contributor
Author
|
Update: I have added the same cabability to
|
2 tasks
Contributor
Author
|
Update 2: I have opened #498. That PR is a more comprehensive and streamlined rewrite, and thus supersedes it, in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in case the file is not read from disk.
This is needed if, for example, files are streamed using a file upload dialog versus read from the file system. Personally, I ran into this limitation using Dash's Upload widget.
There are some basic ToDos:
However, with this PR the code is starting to get a bit messy. I propose the following changes to make it cleaner again (happy to oblige within the PR if accepted):
Nonetest against sig_dataLet me know what you think.